refactor(bitswap): performance improvements #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create fewer copies of wantlist. - Fewer iterations of wantlist when processing received message. These changes make some minor improvements and separates these from functional changes in other PR(s).
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 59.79% 59.84% +0.04%
==========================================
Files 238 238
Lines 29984 29976 -8
==========================================
+ Hits 17930 17939 +9
+ Misses 10434 10424 -10
+ Partials 1620 1613 -7
|
lidel
changed the title
lidel
changed the title
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
* Minor performance improvements around wantlist handling - Create fewer copies of wantlist. - Fewer iterations of wantlist when processing received message. These changes make some minor improvements and separates these from functional changes in other PR(s). * Do not try to process empty emssages * Do not let splitWants modify entries list argument, but pass in message instead * increase timeouts to fix flaky tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make some minor improvements and separate these from functional changes in other PR(s).
(lidel) likely closes #625 closes #626